Remove inappropriate @boundscheck
#311
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quinnj
approved these changes
Apr 30, 2025
Can you suggest a representative benchmark I could run? Is it enough to just print the JSON representation of bunch of numbers? I tried the following: using JSON3, BenchmarkTools
struct T
a::Int
b::Float64
c::String
null::Nothing
maybe::Union{Int, Nothing}
end
t = T(1232423567890, 12.345678901234, "ABCDEFGHIJKLMNOPQRSTUVXYZ", nothing, 1234567890123)
@btime JSON3.write(IOBuffer(), $t)I observe the following measurements: Should I also update the CI action versions so that the tests run? |
|
Action versions updated. |
When running julia with `--check-bounds=no`, the package fails to precompile. The reason is that compiler elides `@boundscheck`s, which in this case removes buffer reallocation. I believe that's unwanted. Issue was [reported on Discourse](https://discourse.julialang.org/t/json3-fails-to-precompile-due-to-embedded-nuls-in-c-strings/128482) by 0samuraiE.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running julia with
--check-bounds=no, the package fails to precompile. The reason is that compiler elides@boundschecks, which in this case removes buffer reallocation. I believe that's unwanted.Issue was reported on Discourse by 0samuraiE.